From 334885af774288c25333ef72b1e6ee22ca66a9e6 Mon Sep 17 00:00:00 2001 From: LynithDev <61880709+LynithDev@users.noreply.github.com> Date: Sat, 21 Dec 2024 12:18:00 +0100 Subject: [PATCH] fix: ClusterSettings excessive CPU and Memory usage --- apps/frontend/src/ui/hooks/useSettings.tsx | 2 -- apps/frontend/src/ui/pages/cluster/ClusterSettings.tsx | 7 ++++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/apps/frontend/src/ui/hooks/useSettings.tsx b/apps/frontend/src/ui/hooks/useSettings.tsx index e817f5c5..633af419 100644 --- a/apps/frontend/src/ui/hooks/useSettings.tsx +++ b/apps/frontend/src/ui/hooks/useSettings.tsx @@ -67,8 +67,6 @@ export function useSettings() { if (!context) throw new Error('useSettingsContext should be called inside its SettingsProvider'); - context.refetch(); - return context; } diff --git a/apps/frontend/src/ui/pages/cluster/ClusterSettings.tsx b/apps/frontend/src/ui/pages/cluster/ClusterSettings.tsx index 29412c76..d58bb81a 100644 --- a/apps/frontend/src/ui/pages/cluster/ClusterSettings.tsx +++ b/apps/frontend/src/ui/pages/cluster/ClusterSettings.tsx @@ -25,7 +25,7 @@ function ClusterSettings() { } function PageSettings(cluster: Accessor) { - const { settings } = useSettings(); + const { settings, save } = useSettings(); // Game const fullscreen = createSetting(cluster().force_fullscreen, settings().force_fullscreen ?? false); @@ -68,6 +68,11 @@ function PageSettings(cluster: Accessor) { custom_env_arguments: envVars.getRaw(), }, })); + + save({ + ...settings(), + java_versions: javaVersions.get(), + }); }); return (