Coverage was over-reported twice, both times by measuring the wrong thing:
once by scanning a plugin root instead of the served bundle set, once with a
non-global regex that returned one hit per file instead of a character count.
Both produced a confident "100%" while the interface was still Chinese, so
the measurement is now part of the repo instead of being done by eye.
- scripts/served.mjs resolves the boot HTML's combo URLs to the on-disk files
the browser receives, searching lib/, client/, dist/ and the package root.
- scripts/measure.mts counts Chinese on the runtime output, decoding \uXXXX
and separating comment text from text that renders.
- README documents the merge order, the comment dictionary, and both traps.
The last Chinese lived in source comments: notes the plugin authors wrote
about why a module exists and which bug it fixed, plus two stylesheet
comment blocks. Comments never render, but they still shipped Chinese, and
the user asked for all of it gone.
- src/dictionary.comments.json: 274 whole comments (block and line form).
- src/rewrite.ts: rewriteComments replaces a comment only on an exact
whole-comment match, so box-drawing runs and the `*` alignment that give
these notes their structure cannot be reflowed by a partial replacement.
Comment rewriting runs on the source between literals; running it over
the assembled output would also scan literal contents, where a URL like
`https://…` reads as a line comment.
- scripts/merge-comments.mjs emits the dictionary and enforces the
invariants: no CJK, delimiters preserved and balanced, line count
unchanged, box runs preserved in block comments. In a single-line `//`
banner the run is decoration and may shift with the text.
Verified on the bytes a fresh instance actually served, escapes decoded:
total Chinese 55,345 -> 111 (99.80% removed). In the browser, both visible
text and the full page HTML report 0 CJK.
The 111 characters left are inside functional regular expressions that
match Chinese *input*: /失败|错误|无法/ classifies a status message,
dshmarket's PREVIEW_WORDS match Chinese plugin descriptions, and
/^[一-龥]{2}$/ validates a two-character name. Translating those would
break plugin behaviour, so they are deliberately left alone.
The remaining Chinese was one measurement bug and one structural gap.
Measurement: the harvester and every earlier gap report walked the profile
tree only. 55 of the 58 served client bundles live in the dsh install tree,
so whole sentences were never in scope and the strict coverage rule left
them in Chinese. Scanning the tree the browser actually receives showed
74.27% coverage, not the ~100% previously claimed.
Structure: rewriteScript skipped every backtick literal, and skipped any
literal containing ${. That is where user-visible text like
`剩余 ${hours} 小时 ${minutes} 分` lived, so it could never be translated.
- scripts/analyze.ts walks the resolved served-bundle set (exported to
~/.cache/c2e/served.json by scripts/served.mjs) instead of a plugin root.
- src/dictionary.residual.json: 1,452 entries covering the measured gap.
- src/rewrite.ts: substituteInterpolated handles template literals. Only an
exact dictionary hit is accepted, because segmenting a template rebuilds
the sentence from word fragments (`已退出 ${n} 个网页端会话` became
`Exited ${n} itemsWeb pageSessions`). A translation that changes the
number of interpolations is rejected.
- src/strings.ts: scanLiteralEnd tracks ${ depth through nested strings and
nested template literals. Previously `` `a ${c ? `b` : ""}` `` was cut at
the inner backtick and rewritten as a fragment.
- scripts/merge-dict.mjs: bilingual keys (`中文 / English`) resolve to their
human-written tail instead of being machine-translated. Also merges the
residual dictionary.
- scripts/mt-fill.mjs: guards templates by interpolation count, skips
bilingual keys, and walks both plugin roots.
Verified over all 78 served bundles via the runtime entry point
translateScript: 54/54 bundles rewritten, residual Chinese in display
literals 9 -> 2 strings (2 CJK chars), both inside CSS comments within a
stylesheet string, so no user-visible text remains. All 5,437 Chinese-bearing
display literals now resolve.
The plugin never translated anything. Its client half monkey-patched locale
internals that do not mutate the locale snapshot, and its DOM walker was
disabled after it crashed the marketplace UI. Nothing else was left.
Move translation to the bundle transport instead. Every third-party bundle is
served through /plugins/ by the clientModules service, so wrapping
bundleResource reaches all of them before any code runs, with no client-side
ordering race and no React tree mutation.
Two bugs surfaced while verifying against the live server:
- The script check tested the path before the query string, but combo requests
are /plugins/??a/client.js,b/client.js&rev=... where the path is just
/plugins/. Every request was rejected.
- bundleResource yields a Buffer, not a string, so the string guard rejected
every request a second time.
Rewriting is all-or-nothing per literal: Chinese has no word boundaries, so
replacing known keys wherever they appear corrupts larger words (当前工作区
became "Saat IniWorkspace"). A literal is translated only when every Chinese
character is covered by a dictionary entry. Two upstream entries were Malay
rather than English and are now corrected.
Each rewritten bundle is parsed with new Function before being served; if that
fails the original bytes are returned, so a bad dictionary entry cannot break
the UI. Verified against the live bundles: both combos compile, and a browser
A/B shows 105 Chinese characters in the Plugins view without the plugin and 0
with it.
The dictionary grows to 1,195 entries (45% of literals, zero partial rewrites)
via a curated supplement merged last so it overrides harvested sources.
