fix(message_input): prevent resource leak in send() method (#662)

This commit is contained in:
Ayyan 2025-12-11 14:35:53 -08:00 • committed by GitHub
parent ffdd141f70
commit f4a092bc24
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -156,6 +156,15 @@ func (mi *messageInput) send() {
return
}
// Close attached files on return
defer func() {
for _, file := range mi.sendMessageData.Files {
if closer, ok := file.Reader.(io.Closer); ok {
closer.Close()
}
}
}()
text = processText(app.chatView.selectedChannel, []byte(text))
if mi.edit {
@ -179,13 +188,6 @@ func (mi *messageInput) send() {
}
}
// Close the attached files after sending the message.
for _, file := range mi.sendMessageData.Files {
if closer, ok := file.Reader.(io.Closer); ok {
closer.Close()
}
}
mi.reset()
app.chatView.messagesList.Highlight()
app.chatView.messagesList.ScrollToEnd()