From fa2a72606483ba8b4de08d3ba2685a982f232f8b Mon Sep 17 00:00:00 2001 From: ayn2op Date: Sun, 1 Jun 2025 20:24:04 -0400 Subject: [PATCH] refactor: replace for loop with if statement --- cmd/messages_text.go | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/cmd/messages_text.go b/cmd/messages_text.go index ab07b4b..ba86243 100644 --- a/cmd/messages_text.go +++ b/cmd/messages_text.go @@ -262,9 +262,9 @@ func (mt *MessagesText) selectedMsgIndex() (int, error) { return -1, err } - for idx, m := range ms { - for m.ID == mt.selectedMessageID { - return idx, nil + for i, m := range ms { + if m.ID == mt.selectedMessageID { + return i, nil } } @@ -306,7 +306,7 @@ func (mt *MessagesText) _select(name string) { return } - messageIdx, err := mt.selectedMsgIndex() + msgIdx, err := mt.selectedMsgIndex() if err != nil { slog.Error("failed to get selected message", "err", err) return @@ -318,8 +318,8 @@ func (mt *MessagesText) _select(name string) { if len(mt.GetHighlights()) == 0 { mt.selectedMessageID = ms[0].ID } else { - if messageIdx < len(ms)-1 { - mt.selectedMessageID = ms[messageIdx+1].ID + if msgIdx < len(ms)-1 { + mt.selectedMessageID = ms[msgIdx+1].ID } else { return } @@ -329,8 +329,8 @@ func (mt *MessagesText) _select(name string) { if len(mt.GetHighlights()) == 0 { mt.selectedMessageID = ms[0].ID } else { - if messageIdx > 0 { - mt.selectedMessageID = ms[messageIdx-1].ID + if msgIdx > 0 { + mt.selectedMessageID = ms[msgIdx-1].ID } else { return } @@ -344,7 +344,7 @@ func (mt *MessagesText) _select(name string) { return } - if ref := ms[messageIdx].ReferencedMessage; ref != nil { + if ref := ms[msgIdx].ReferencedMessage; ref != nil { for _, m := range ms { if ref.ID == m.ID { mt.selectedMessageID = m.ID